| From: | Jim Doty <jdoty(at)pivotal(dot)io> |
|---|---|
| To: | iwata(dot)aya(at)jp(dot)fujitsu(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org, nagata(at)sraoss(dot)co(dot)jp, peter(dot)eisentraut(at)2ndquadrant(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: libpq debug log |
| Date: | 2018-11-12 20:51:15 |
| Message-ID: | CAKJcHDe6+k1z36H3GbehSf2qbuM4yQSgV9eU8bBmCW-BNOHN_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
This is my first attempt at a patch review, so I will take a pass at the
low hanging fruit.
Initial Pass
============
+ Patch applies
+ Patch builds
+ Patch behaves as described in the thread
I tried a few small things:
When I set a relative path for `PGLOGDIR`, the files were correctly
written to the directory.
When I set a path for `PGLOGDIR` that didn't exist or was not
write-able, the patch writes no files, and does not alert the user that
no files are being written.
Performance
===========
I ran two permutations of make check, one with the patch applied but not
activated, and the other with with the files being written to disk. Each
permutation was run ten times, and the stats are below (times are in
seconds):
min max median mean
not logging 50.4 57.6 53.3 53.4
logging 58.3 77.7 65.0 65.8
Cheers,
Jim Doty
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-11-12 21:20:42 | Re: Small run-time pruning doc fix |
| Previous Message | Robert Haas | 2018-11-12 20:45:28 | Re: Copy data to DSA area |