Re: [HACKERS] Runtime Partition Pruning

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: [HACKERS] Runtime Partition Pruning
Date: 2018-02-27 09:50:24
Message-ID: CAKJS1f_rPuzKvTg+uO95hepEoyx9zHe1rriC4zAO2z8ga7VgyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27 February 2018 at 22:39, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> I've incorporated portions of 0002 and 0003 into my patch on the other
> thread (v34) posted at [1]. That is, mostly the changes around handling
> OR clauses and interface changes resulting from it.

Thanks. I was just in the middle of swapping the order of the patches
so that the OR clause patch was directly based on yours.

> Attached are revised version of your patches after the aforementioned
> rearrangements. Note that after I took out the optimizer portion of the
> 0003 patch to incorporate it into my patch (OR clause processing bits),
> not much was left in it, so I squashed it into 0002. So there are only
> 0001 and 0002.

I've locally got a patch which is significantly different to the v12
patch which moves lots of code into nodePartition.c and fixes up the
missing node read/write functions too.

> As a review comment on 0002, I think trypartitionprune is better written
> as try_partition_prune.

That no longer exists in the new version... Will post soonish, just
need to base it all on your v34 [1] now! :)

[1] https://www.postgresql.org/message-id/158f04ce-9deb-0457-ddcc-78fb73db4ebc%40lab.ntt.co.jp

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2018-02-27 10:05:48 Re: 2018-03 CFM
Previous Message Amit Langote 2018-02-27 09:39:47 Re: [HACKERS] Runtime Partition Pruning