| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Small improvement to get_base_rel_indexes() |
| Date: | 2015-08-15 10:45:55 |
| Message-ID: | CAKJS1f__ObP8T=eRkAqJ5iik47QtDv_B5FrAkLkUsPOcO8L66w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attached is a small patch which improves the way get_base_rel_indexes()
works.
The current version creates a new bitmapset on each recursion level then
bms_joins() to the one on the next level up each time. I understand that
this will patch will have about a 0 net performance improvement, but I
thought I'd post anyway as:
1. It removes 5 lines of code.
2. It's a better example to leave in the code.
Is it worth applying?
Regards
David Rowley
--
David Rowley http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| get_base_rel_indexes_cleanup.diff | text/plain | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-08-15 12:16:11 | Re: replication slot restart_lsn initialization |
| Previous Message | Petr Jelinek | 2015-08-15 09:45:47 | Re: Test code is worth the space |