Re: pgsql: New C function: bms_add_range

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: New C function: bms_add_range
Date: 2017-11-30 20:53:54
Message-ID: CAKJS1f_0iSiLQsf_c06AzOWAc3eS6ePjjVQFpcFv3W-O5aktnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 30 November 2017 at 14:48, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Nov 29, 2017 at 8:27 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> To be accurate, as also noted in the commit message of the patch that I
>> sent, authors of this patch are David Rowley and Kyotaro Horiguchi. David
>> came up with the idea and the patch first [1], which Horiguchi-san later
>> commented on to improve the code. My job has simply been to incorporate
>> their patch in the bigger patch set.
>
> Crap, I apologize. I looked at the commit message you wrote in
> putting together mine, but I somehow blanked out the fact that you had
> listed David rather than yourself as first author. That was bad of
> me, and I am sorry.

Unfortunate, but you're forgiven :-p

I've attached a small patch to fix the comment at the head of the
function. I thought I had fixed this, but seems I didn't.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
bms_add_range_comment_fix.patch application/octet-stream 724 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-11-30 21:27:11 pgsql: Remove extra word from comment.
Previous Message Peter Eisentraut 2017-11-30 19:49:13 Re: [COMMITTERS] pgsql: Add more efficient functions to pqformat API.