| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Incorrect comment in get_partition_dispatch_recurse |
| Date: | 2018-05-14 04:57:45 |
| Message-ID: | CAKJS1f9yyimYyFzbHM4EwE+tkj4jvrHqSH0H4S4Kbas=UFpc9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed that a comment in get_partition_dispatch_recurse claims that:
"it contains the
* leaf partition's position in the global list *leaf_part_oids minus 1"
The "minus 1" part is incorrect. It simply just stores the 0-based
index of the item in the list. I was going to fix it by removing just
that part, but instead, I ended up rewriting the whole thing.
Patch attached.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| get_partition_dispatch_recurse_comment_fix.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-05-14 05:00:34 | Re: Needless additional partition check in INSERT? |
| Previous Message | Ashutosh Bapat | 2018-05-14 04:51:25 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |