Re: pgsql: Remove useless default clause in switch

On 24 April 2018 at 13:50, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> David Rowley wrote:
>> On 24 April 2018 at 03:12, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> > Remove useless default clause in switch
>> >
>> > The switch covers all values of the enum driver variable, so having a
>> > default: clause is useless, even if it's only to do Assert(false).
>>
>> Just for my own understanding:
>>
>> I always thought that when all options were covered that we generally
>> kept a default just in case someone added another enum and forgot to
>> update the code.
>
> The compiler will emit a warning when it sees that not all cases are
> handled, so it's not necessary to have a default case.

Thank you all for explaining that. It very much makes sense now.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services