Re: Should we add GUCs to allow partition pruning to be disabled?

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Should we add GUCs to allow partition pruning to be disabled?
Date: 2018-04-26 02:54:42
Message-ID: CAKJS1f9u9svzEh-e55WRYzVTLpWi2Ek4b-UAM93k_M24nJMc9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24 April 2018 at 09:10, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I just pushed David patch, with some pretty minor changes. I hope not
> to have broken anything.

Thanks for pushing and thanks Amit for reviewing.

The only thing that stands out in the actual commit is:

+ executor to remove (ignore) partitions during query execution. The

I had originally written:

+ executor to remove or ignore partitions during query execution. The

The reason I was using "remove or ignore" was that partitions pruned
during init plan are effectively "removed" from the plan, whereas
partitions pruned during the running of the planner are just
"ignored".

It's minor details but I thought I'd better point it out.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2018-04-26 03:03:55 Re: Format base - Code contribution
Previous Message Peter Geoghegan 2018-04-26 02:40:40 Re: [HACKERS] Clock with Adaptive Replacement