From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Surafel Temesgen <surafel3000(at)gmail(dot)com> |
Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump multi VALUES INSERT |
Date: | 2019-01-02 22:37:59 |
Message-ID: | CAKJS1f9i9acpes7Q7rWKnfSjjwh81RmkxaH_tGsTd_2kgbLo1w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 3 Jan 2019 at 01:50, Surafel Temesgen <surafel3000(at)gmail(dot)com> wrote:
> On Mon, Dec 31, 2018 at 12:38 PM David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> Just looking at the v5 patch, it seems not to handle 0 column tables correctly.
> The attach patch contain a fix for it
+ /* if it is zero-column table then we're done */
+ if (nfields == 0)
+ {
+ archputs(insertStmt->data, fout);
+ continue;
+ }
So looks like you're falling back on one INSERT per row for this case.
Given that this function is meant to be doing 'dump_inserts_multiple'
INSERTs per row, I think the comment should give some details of why
we can't do multi-inserts, and explain the reason for it. "we're done"
is just not enough detail.
I've not looked at the rest of the patch.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alexey Bashtanov | 2019-01-02 22:53:12 | Re: log bind parameter values on error |
Previous Message | Tom Lane | 2019-01-02 21:48:03 | Re: Is MinMaxExpr really leakproof? |