Re: PATCH: use foreign keys to improve join estimates v1

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: use foreign keys to improve join estimates v1
Date: 2015-12-24 04:23:09
Message-ID: CAKJS1f9_tsFS6CH9_=g8rO-CQu_4ycowOOXe1W50m9w2-mcKbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24 December 2015 at 16:32, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
wrote:

>
>
> On 12/24/2015 03:45 AM, Michael Paquier wrote:
>
>> On Wed, Sep 30, 2015 at 10:12 AM, David Rowley
>>
> ...
>
>> In the attached I've coded it to take the Min() selectivity for when the
>>> same quals are matched more than once. I know this is not correct, but
>>> since
>>> it seems impossible to obtain an exact estimate in this case, we'd need
>>> to
>>> decide on some logic which does well in the average case.
>>>
>>
>> Is there still an interest for this patch? The last message of this
>> thread has added a new version of the patch but the patch was still in
>> "Waiting on author" state for a couple of months. Just guessing that
>> the status was incorrect, I have moved it to next CF.
>>
>
> Yes, I still think the patch is useful. Thanks for moving it to the next
> commitfest and sorry for not updating the status.

Hi,

I'm not sure that I agree with this being set to "Needs review". The last
progress that I see made on this was me hacking at the patch to remove some
equivalence class limitations. I think the logical next step would be for
you to look at these changes and either accept or reject them. So does that
not suit "Waiting on author" better than "Needs review" ?

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-12-24 04:57:10 Re: On-demand running query plans using auto_explain and signals
Previous Message Haribabu Kommi 2015-12-24 04:16:29 Re: pg_hba_lookup function to get all matching pg_hba.conf entries