| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | extern keyword incorrectly used in some function definitions |
| Date: | 2018-02-19 09:40:02 |
| Message-ID: | CAKJS1f9RKLWXcMBQhvDYhmsMEo+ALuNgA-NE+AX5Uoke9DJ2Xg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While poking around partition.c I noticed that one of the functions
there is *defined* as "extern". Normally we'd only do this in the
declaration of the function. I don't really see why it's needed in the
definition.
Anyway, I removed it. I then thought I'd better look around for any
others too...
A patch is attached which removes them all, apart from the snowball
ones. I didn't touch those.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| remove_extern_func_defs.patch | application/octet-stream | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2018-02-19 12:03:51 | NEXT VALUE FOR sequence |
| Previous Message | Amit Langote | 2018-02-19 09:19:29 | Re: [HACKERS] path toward faster partition pruning |