From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Fix compiler warnings in Cube Extension |
Date: | 2015-12-28 10:26:04 |
Message-ID: | CAKJS1f9Dw-2DwP4hPvNk3HFNSd=tFH92t79OHvEZhmtXrH5sOQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
My compiler is complaining about cube_coord() and cube_coord_llur() not
returning a value on all code paths. On looking at this I noticed that
this is happening due the pattern used is not quite aligned with other
code, as normally we do:
if (<error condition>)
ereport(<some error>);
do stuff;
PG_RETURN_....(value);
I've rearranged the code to be aligned more with what's normal. In passing
I also adding some missing and removed some unneeded parenthesis, and also
adjusted some white space.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
cube_warning_fix.patch | application/octet-stream | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2015-12-28 10:38:16 | Re: WIP: bloom filter in Hash Joins with batches |
Previous Message | Tomas Vondra | 2015-12-28 10:23:08 | Re: WIP: bloom filter in Hash Joins with batches |