| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Rethinking representation of partial-aggregate steps |
| Date: | 2016-06-26 20:22:38 |
| Message-ID: | CAKJS1f9=GpUn3eLorCM0XJz3BMaUhmXwC0ZX3Xk4q1=q_AXD4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27 June 2016 at 03:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Looking at this in the light of morning, I'm rather strongly tempted to
> invert the sense of the FINALIZE option, so that "simple" mode works out
> as zero, ie, select no options. Maybe call it SKIPFINAL instead of
> FINALIZE?
Aggref calls this aggpartial, and I was tempted to invert that many
times and make it aggfinalize, but in the end didn't.
It seems nicer to me to keep it as a list of things that are done,
rather than to make one exception to that just so we can have the
simple mode as 0.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-06-26 20:25:24 | Non-text EXPLAIN output for partial aggregation |
| Previous Message | Tom Lane | 2016-06-26 18:38:12 | Re: Memory leak in Pl/Python |