bug in citext's upgrade script for parallel aggregates

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, andreas(at)proxel(dot)se
Subject: bug in citext's upgrade script for parallel aggregates
Date: 2016-06-24 11:31:01
Message-ID: CAKJS1f8zOoDN1nxhYXi08UWeTUNNrmaVZ6Jg1vhWLCpRdL5_gg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Seems there's a small error in the upgrade script for citext for 1.1
to 1.2 which will cause min(citext) not to be parallel enabled.

max(citext)'s combinefunc is first set incorrectly, but then updated
to the correct value. I assume it was meant to set the combine
function for min(citext) instead.

Fix attached. I've assumed that because we're still in beta that we
can get away with this fix rather than making a 1.3 version to fix the
issue.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
citext_1.1_to_1.2_upgrade_fix.patch application/octet-stream 600 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-06-24 13:34:58 Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)
Previous Message Haroon Muhammad 2016-06-24 10:41:00 Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)