| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Speeding up INSERTs and UPDATEs to partitioned tables |
| Date: | 2018-11-08 11:28:09 |
| Message-ID: | CAKJS1f8yNGQLspFkfc-0LAAnUQgv1d9uv0eE4tiwpJLfofsBYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8 November 2018 at 20:15, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Actually, as I also proposed upthread, we should move root_tuple_slot from
> PartitionTupleRouting to ModifyTableState as mt_root_tuple_slot, because
> it's part of the first step described above that has nothing to do with
> partition tuple routing proper. We can make PartitionTupleRouting private
> to execPartition.c if we do that.
okay. Makes sense. I've changed things around to PartitionTupleRouting
is now private to execPartition.c
> I didn't find anything quite significant to complain about, except just
> one line:
>
> + * Initially we must only setup 1 PartitionDispatch object; the one for
>
> setup -> set up
Changed too.
I've attached v15 and a delta from v14 to ease re-review.
I also ran pgindent on this version. That's not part of the delta but
is in the main patch.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v14_v15.diff | application/octet-stream | 13.9 KB |
| v15-0001-Speed-up-INSERT-and-UPDATE-on-partitioned-tables.patch | application/octet-stream | 73.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yuzuko Hosoya | 2018-11-08 11:35:09 | RE: A typo in partprune.c |
| Previous Message | Tomas Vondra | 2018-11-08 11:22:04 | Re: jsonpath |