| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Subject: | Needless additional partition check in INSERT? |
| Date: | 2018-05-10 03:55:02 |
| Message-ID: | CAKJS1f8w8+awsxgea8wt7_UX8qzOQ=Tm1LD+U1fHqBAkXxkW2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Scanning ExecInsert, it looks like there's a needless additional
partition constraint check against the tuple. This should only be
required if there's a before row INSERT trigger. The code block up
one from the additional check tries to disable the check, but it goes
ahead regardless, providing there's some other constraint.
ExecFindPartition should have already located the correct partition
and nothing should have changed in the absence of before row insert
triggers, so it looks like we're fine to not bother re-checking.
Or did I misunderstand?
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| remove_needless_additional_partition_check.patch | application/octet-stream | 611 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2018-05-10 04:04:33 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |
| Previous Message | Amit Langote | 2018-05-10 03:00:13 | Re: Indexes on partitioned tables and foreign partitions |