| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tels <nospam-pg-abuse(at)bloodgate(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Froehlich <s(dot)froehlich(at)cablelabs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Date: | 2018-01-27 21:09:15 |
| Message-ID: | CAKJS1f8qbLYCkU83io-yMLKDmWiR7Zpy=ixwEki-u9-wGOUgpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-novice |
On 27 January 2018 at 00:03, Tels <nospam-pg-abuse(at)bloodgate(dot)com> wrote:
> Looking at the patch, at first I thought the order was sorted and you
> swapped STORAGE and STATISTICS by accident. But then, it seems the order
> is semi-random. Should that list be sorted or is it already sorted by some
> criteria that I don't see?
>
> - <literal>INCLUDING DEFAULTS INCLUDING IDENTITY INCLUDING
> CONSTRAINTS INCLUDING INDEXES INCLUDING STORAGE INCLUDING
> COMMENTS</literal>.
> + <literal>INCLUDING DEFAULTS INCLUDING IDENTITY INCLUDING
> CONSTRAINTS INCLUDING INDEXES INCLUDING STORAGE INCLUDING STATISTICS
> INCLUDING COMMENTS</literal>.
It looks like they were in order of how they're defined in enum
TableLikeOption up until [1], then I'm not so sure what the new order
is based on after that.
I'd offer to put it back to the order of the enum, but I want to
minimise the invasiveness of the patch. I'm not sure yet if it should
be classed as a bug fix or a new feature.
On looking at this I realised I missed changing the syntax synopsis.
The attached adds this.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| create_table_like_statistics_v2.patch | application/octet-stream | 20.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-01-27 21:20:37 | Re: JIT compiling with LLVM v9.0 |
| Previous Message | Daniel Gustafsson | 2018-01-27 20:19:22 | Re: [HACKERS] Refactoring identifier checks to consistently use strcmp |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-01-27 21:45:41 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Previous Message | Andreas Kretschmer | 2018-01-27 10:35:05 | Re: syntax error on Function return setoff |