| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Refactoring identifier checks to consistently use strcmp |
| Date: | 2018-01-27 20:19:22 |
| Message-ID: | 70B5CE04-A92E-45B7-A99C-EE6CBF11721D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Jan 2018, at 00:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I've pushed this mostly as-is.
Thanks!
> I also took out the parser changes related to
> allowing unquoted PARALLEL in old-style CREATE AGGREGATE, because that
> is not a goal I consider worthy of adding extra grammar complexity.
> We don't document that PARALLEL works there, and there has never been
> any expectation that deprecated legacy syntax would grow new options
> as needed to have feature parity with the modern syntax.
Ok, didn’t know old syntax wasn’t extended to support new options so I went
after it having run into the regress tests using it.
> I also trimmed the new regression test cases a bit, as most of them seemed
> pretty duplicative.
Makes sense, they were made verbose to aid review but were too chatty for
inclusion.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-01-27 21:09:15 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Previous Message | Arthur Zakirov | 2018-01-27 19:19:08 | Re: [HACKERS] PoC: custom signal handler for extensions |