| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Custom table AMs need to include heapam.h because of BulkInsertState |
| Date: | 2019-07-01 13:26:26 |
| Message-ID: | CAKJS1f8a9Qz0bgs-R_Y1u_znNVupcisApBCZf509=7utYw_EuA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 30 Jun 2019 at 17:54, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> Any further thoughts on this Michael?
>
> Or Andres? Do you have a preference to which of the approaches
> (mentioned upthread) I use for the fix?
>
> If I don't hear anything I'll probably just push the first fix. The
> inefficiency does not affect heap, so likely the people with the most
> interest in improving that will be authors of other table AMs that
> actually do something during table_finish_bulk_insert() for
> partitions. We could revisit this in PG13 if someone comes up with a
> need to improve things here.
I've pushed the original patch plus a small change to only call
table_finish_bulk_insert() for the target of the copy when we're using
bulk inserts.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Binguo Bao | 2019-07-01 13:46:28 | Re: Optimize partial TOAST decompression |
| Previous Message | Thomas Munro | 2019-07-01 12:20:32 | Re: Commitfest 2019-07, the first of five* for PostgreSQL 13 |