| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Surafel Temesgen <surafel3000(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump multi VALUES INSERT |
| Date: | 2019-02-03 08:39:56 |
| Message-ID: | CAKJS1f8SZqFcOSws4i4BwZ-4i9+Ki9_n40ta+_WY0=OPodAUMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 3 Feb 2019 at 21:00, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> >> There is a test, that is good! Charater "." should be backslashed in the
> >> regexpr.
> >
> > Yeah, you're right. I wonder if we should fix the test of them in
> > another patch.
>
> From a software engineering perspective, I'd say that a feature and its
> tests really belong to the same patch.
I meant to say "fix the rest" if them, not "the test of them".
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-02-03 09:07:37 | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
| Previous Message | Andrew Gierth | 2019-02-03 08:14:44 | Re: Early WIP/PoC for inlining CTEs |