| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Runtime partition pruning for MergeAppend |
| Date: | 2018-07-19 12:36:17 |
| Message-ID: | CAKJS1f8M78gMxGryFhUXKscW7rxPQodYi+K=tF+YOvZ9yj-E9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19 July 2018 at 22:50, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> Looks solid. The only actual bug I see is that this doesn't honor the
> enable_partition_pruning GUC, but that's trivial to fix. So fixed that,
> reworded some of the comments a tiny bit, and committed. Thanks!
I just noticed I managed to miss updating "Append" to "MergeAppend"
when copying a comment out of nodeAppend.c into nodeMergeAppend.c. I
see you noticed it but accidentally updated the comment in
nodeAppend.c.
The attached fixes.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| mergeappend_runtime_pruning_fixup.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-07-19 12:38:40 | Re: pgbench's expression parsing & negative numbers |
| Previous Message | Heikki Linnakangas | 2018-07-19 12:28:05 | Re: GiST VACUUM |