| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench MAX_ARGS |
| Date: | 2019-03-11 10:07:25 |
| Message-ID: | CAKJS1f8K8J8TutZM-=WNo3n4Xbv=vNuOkZwNPJjwyEYKTTxHMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 11 Mar 2019 at 12:37, Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
>
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> > I think some comments in the area to explain the 0th is for the sql
> > would be a good idea too, that might stop any confusion in the
> > future. I see that's documented in the struct header comment, but
> > maybe worth a small note around that error message just to confirm the
> > - 1 is not a mistake, and neither is the >= MAX_ARGS.
>
> I have done this in the updated version of the patch, attached.
> Setting back to NR.
The patch looks good to me. I'm happy for it to be marked as ready for
committer. Fabien, do you want to have another look?
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2019-03-11 10:11:44 | Re: Offline enabling/disabling of data checksums |
| Previous Message | MikalaiKeida | 2019-03-11 09:07:11 | RE: Timeout parameters |