Re: pgsql: Improve index AMs' opclass validation procedures.

On 22 January 2016 at 13:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Improve index AMs' opclass validation procedures.
>
> The amvalidate functions added in commit 65c5fcd353a859da were on the
> crude side. Improve them in a few ways:
>
> * Perform signature checking for operators and support functions.
>
> * Apply more thorough checks for missing operators and functions,
> where possible.
>
> * Instead of reporting problems as ERRORs, report most problems as INFO
> messages and make the amvalidate function return FALSE. This allows
> more than one problem to be discovered per run.
>
> * Report object names rather than OIDs, and work a bit harder on making
> the messages understandable.
>
> Also, remove a few more opr_sanity regression test queries that are
> now superseded by the amvalidate checks.

I'm getting 3 new warnings with this change which mention about 32-bit
bit shifting then bitwise anding to a 64-bit variable.

The attached fixes the warnings

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services