| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Should we add GUCs to allow partition pruning to be disabled? |
| Date: | 2018-05-09 02:59:15 |
| Message-ID: | CAKJS1f-ypxYtvON5JH5Si+d18G+fPZCE=M81da7TnNznNa7fiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for reviewing again.
On 9 May 2018 at 01:32, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> On Mon, May 07, 2018 at 06:00:59PM +1200, David Rowley wrote:
>> Many thanks for reviewing this.
>
> 2nd round - from the minimalist department:
>
> + partitions which cannot possibly contain any matching records.
> maybe: partitions which cannot match any records.
I don't think that's an improvement. I don't think there's such a
thing as "partitions which match records". A partition can contain a
record, it never matches one.
> + <para>
> + Partition pruning done during execution can be performed at any of the
> + following times:
>
> remove "done"?
Removed.
> + number of partitions which were removed during this phase of pruning by
> remove "of prunning"
Removed.
v3 attached.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| further_enable_partition_pruning_doc_updates_v3.patch | application/octet-stream | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2018-05-09 03:21:20 | Re: parallel.sgml for Gather with InitPlans |
| Previous Message | Tsunakawa, Takayuki | 2018-05-09 02:52:32 | RE: Having query cache in core |