Re: Refactor to split nodeAgg.c?

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactor to split nodeAgg.c?
Date: 2015-06-30 10:37:57
Message-ID: CAKJS1f-nZV0OzcX=NryzQijN6JE=zY5ZjXfNUyESj0ck9t9=kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30 June 2015 at 14:33, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:

> I was going to rebase my HashAgg patch, and got some conflicts related
> to the grouping sets patch. I could probably sort them out, but I think
> that may be the tipping point where we want to break up nodeAgg.c into
> nodeSortedAgg.c and nodeHashAgg.c, and probably a common file as well.
>
> This would also (I hope) be convenient for Simon and David Rowley, who
> have been hacking on aggregates in general.
>
>
That would be more inconvenient right now as I have a pending patch which
makes quite a number of changes which are all over nodeAgg.c.
https://commitfest.postgresql.org/5/271/

Regards

David Rowley

--
David Rowley http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-06-30 10:49:07 Re: PANIC in GIN code
Previous Message Andres Freund 2015-06-30 09:48:59 Re: Refactor to split nodeAgg.c?