| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Clarify use of temporary tables within partition trees |
| Date: | 2018-07-03 09:30:20 |
| Message-ID: | CAKJS1f-SB+cAgS82KNYcBbiHR=NYFpx8s9J6+B01vdWOeeDrqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3 July 2018 at 21:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Yeah. Actually I'd like to add a test as well to test the recursion
> call of expand_partitioned_rtentry. If you have an idea, please let me
> know or I'll figure out one by myself and add it probably in
> create_table.sql.
What specifically do you want to test? There are plenty of partitioned
tests with sub-partitioned tables. Going by [1], there's no shortage
of coverage.
Of course, the dead code I'm proposing we remove is not covered.
There's no way to cover it... it's dead.
[1] https://coverage.postgresql.org/src/backend/optimizer/prep/prepunion.c.gcov.html
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-07-03 09:50:15 | Re: pgsql: Clarify use of temporary tables within partition trees |
| Previous Message | Michael Paquier | 2018-07-03 09:15:07 | Re: pgsql: Clarify use of temporary tables within partition trees |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-07-03 09:50:15 | Re: pgsql: Clarify use of temporary tables within partition trees |
| Previous Message | Michael Paquier | 2018-07-03 09:15:07 | Re: pgsql: Clarify use of temporary tables within partition trees |