Re: REPACK and naming

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: REPACK and naming
Date: 2025-09-18 23:03:59
Message-ID: CAKFQuwbqXLogKbUPiHN9h88FEVP-Oem-tv5n3CyKoGCzpNM1gA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 18, 2025 at 3:55 PM Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:

> On 2025-Sep-17, David G. Johnston wrote:
>
> > On Wednesday, September 17, 2025, David Rowley <dgrowleyml(at)gmail(dot)com>
> wrote:
> >
> > > On Thu, 18 Sept 2025 at 01:09, Robert Haas <robertmhaas(at)gmail(dot)com>
> wrote:
> > > > RETABLE just isn't a word. The code sometimes calls this a REWRITE of
> > > > a table, which would be reasonable.
> > >
> > > +1. I was reading this yesterday wondering why "REWRITE" didn't get a
> > > mention.
> >
>
> I'm not particularly excited about REWRITE, as it sounds a little bit
> too generic, plus we already have the "query rewriter" which rewrites,
> and I think it would be good that we stop overloading terms for
> completely different things.
>

Agreed

> > Rebuild has some prior art apparently, which makes it appealing.
>
> Can you cite that? I've seen "ALTER TABLE/INDEX REBUILD", but not
> REBUILD as a standalone command.
>
>
I was just skimming the list Mikhail provided.

https://www.postgresql.org/message-id/CADzfLwXjBvqQCuPOaMGe20a+ySTcqSpfvoGyZZmrMkJ=HbtcOw@mail.gmail.com

It isn't standalone but the keyword REBUILD gets used versus our unlisted
use of REPACK.

But there isn't enough consistency/similarity for me to want to avoid
repack altogether.

David J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-09-18 23:21:06 Re: Invalid primary_slot_name triggers warnings in all processes on reload
Previous Message Álvaro Herrera 2025-09-18 22:55:51 Re: REPACK and naming