Re: Event trigger code comment duplication

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Event trigger code comment duplication
Date: 2020-05-14 23:27:40
Message-ID: CAKFQuwbiLCtOOMm52rkro5hSGZtFo-CBcQvYOVSi=bwqEB2MoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 14, 2020 at 4:25 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Wed, May 13, 2020 at 04:48:59PM +0900, Michael Paquier wrote:
> > Still not sure that's worth bothering. So, let's wait a couple of
> > days first to see if anybody has any comments, though I'd like to just
> > go with the simplest solution at hand and remove only the duplicated
> > comment about the standalone business with event triggers.
>
> I have gone through this one again this morning, and applied the
> simple version as merging the checks on the current event trigger
> state would make us lose some context about why each event gets
> skipped.
>
>
Ok. Thanks!

David J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-05-14 23:52:20 Re: POC: GROUP BY optimization
Previous Message Michael Paquier 2020-05-14 23:25:46 Re: Event trigger code comment duplication