| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Alexander Borisov <lex(dot)borisov(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Non-committer reviews: is it helpful? |
| Date: | 2026-01-29 22:20:45 |
| Message-ID: | CAKFQuwba2iFVyLb3+Jab5ruWdPxNqBCFVFMDeCdmT_hVUYm43w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 29, 2026 at 3:07 PM Alexander Borisov <lex(dot)borisov(at)gmail(dot)com>
wrote:
> I have a question for the community. While waiting for feedback on my
> own patches, I was wondering: is there value in me reviewing other
> people's patches, even though I am not a committer here?
>
>
Non-committers moving patches from "needs review" to "ready for committer"
is a critical activity here. It is part of the soft contract one enters
into when authoring patches - to try and perform an amount of review work
equivalent to what you are asking from others.
As for which ones to review - everyone has their own natural prioritization
methodology (and capabilities) just by interacting with the project and
community. I'd suggest you don't overthink things and just do what feels
right to you.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-01-29 22:24:02 | Re: Optional skipping of unchanged relations during ANALYZE? |
| Previous Message | Nathan Bossart | 2026-01-29 22:17:43 | Re: split tablecmds.c |