Re: [Util] Warn and Remove Invalid GUCs

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Shaik Mohammad Mujeeb <mujeeb(dot)sk(at)zohocorp(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, mujeebskdev <mujeeb(dot)sk(dot)dev(at)gmail(dot)com>
Subject: Re: [Util] Warn and Remove Invalid GUCs
Date: 2025-05-22 21:53:06
Message-ID: CAKFQuwbP=d-VyzLsasXdUY0O-BniAK_Detd1ChCKc0fOwNEpdQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 22, 2025 at 8:43 AM Shaik Mohammad Mujeeb <
mujeeb(dot)sk(at)zohocorp(dot)com> wrote:

> I do understand that not everyone may prefer seeing such warnings during
> PG server restart. To address this, we could introduce a new GUC (perhaps
> named *warn_on_unregistered_guc_prefix*), which defaults to false,
> preserving the existing behaviour. If explicitly enabled, it would emit
> warnings for these cases, giving users the choice to opt in to this
> feedback.
>
>
> Thoughts on this approach?
>

The need for yet another GUC makes this considerably less appealing than it
already is.

I see and agree with the problem statement posed here but would prefer an
approach that improves the UX to minimize such mistakes or encourages
people to check their settings more easily to ensure that they didn't type
100 when they meant to type 10 for the correct setting name. In short,
warning in limited places for a subset of potential errors when doing so
involves false positives is just an unappealing change.

David J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthew Sterrett 2025-05-22 21:54:28 Re: Proposal for enabling auto-vectorization for checksum calculations
Previous Message David G. Johnston 2025-05-22 21:46:10 Re: [Util] Warn and Remove Invalid GUCs