| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Lukas Fittl <lukas(at)fittl(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Dian Fay <di(at)nmfay(dot)com>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_plan_advice |
| Date: | 2026-01-29 04:58:26 |
| Message-ID: | CAKFQuwbOt+19OBwKh91cKZyBP4RHuVuCtR8sKs4UH5QUu1GLew@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 28, 2026 at 10:14 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Jan 12, 2026 at 12:13 PM Robert Haas <robertmhaas(at)gmail(dot)com>
> wrote:
> > If not, I'll rearrange
> > the series to move 0004 to the front, and plan to commit that first.
>
> That rearrangement got done in v11, and I've now committed that patch
> after fixing a few typos that I found. Cautiously, woohoo, but let's
> see if anything breaks.
>
> Here's v13.
>
Documentation review patch attached.
Overall it flowed well. Most of the changes are just typos or similar.
I found the idea of seeing "Disabled: true" to not make immediate sense.
I've left some comments near that section and plan to come back to it.
The comment about collector memory usage was duplicated more-or-less. I
kept the first, less loud, instance.
Removed the few uses of "we" in favor of pg_plan_advice being the actor.
David J.
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-Docs-review.patch | text/x-patch | 18.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2026-01-29 05:00:00 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | jian he | 2026-01-29 03:53:39 | Re: ERROR: failed to find conversion function from unknown to text |