Re: Documentation improvement patch

On Fri, Oct 9, 2026 at 10:43 AM Matemática A3K <matematica(dot)a3k(at)gmail(dot)com>
wrote:

> On Fri, Oct 9, 2026 at 9:46 AM Oleg <o(dot)sibiryakov(at)postgrespro(dot)ru> wrote:
>
>> Dear all,
>>
>> I have prepared a patch containing some minor inconsistencies in the documentation.
>> Please, take a look.
>>
>> I will be looking forward to your feedback.
>>
>
> Mine would be: "Wow! What a sharp eye! Congratulations! I reviewed all
> your proposed changes and agree with all of them, +1"
>
>
Neither of the first two changes seems correct to me.

Third one is good. So maybe it's just the wanting to use commas where they
are unnecessary or incorrect that I'd push back on.

First it correctly adds missing periods then incorrectly removes others.

Using substring makes sense.

Most of these do seem to be unambiguous corrections.

For Oid -> OID - the documentation is inconsistent but favors Oid ...

/*
- * Retrieve the string value of an HBA option which was registered via
+ * Retrieve the string value of an HBA option, which was registered via
* RegisterOAuthHBAOptions(). Usable only during validate_cb or
shutdown_cb.
*

Another unneeded comma and passed up the chance to use 'that' like in prior
changes.

I stopped about half way. Suggest breaking these according to the problem
being corrected. But I don't trust your present ability to know when to
introduce commas to the prose. I am also unsure whether we really care
about adhering to Oxford commas.

David J.