Re: Commitfest overflow

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Commitfest overflow
Date: 2021-08-07 21:11:25
Message-ID: CAKFQuwawFXUQyMt0JSqx4LSiaTyT6Zp1KsFnELA2VgYqOb63aw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 5, 2021 at 7:36 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Patches that are not being updated regularly have no
> business being part of a CommitFest.
>

As the main issue seems to be "Needs Review" getting punted, the patch
author rightly expects feedback before supplying new patches. If they are
waiting for months, that isn't on them.

> I don't think a patch should be
> rejected on the strength of a single -1, but when 2 or 3 people have
> shown up to say either that they don't like the idea or that the
> implementation is way off base, it's not helpful to leave things in a
> state that suggests it needs more eyeballs.
>
>
I would agree. One of those 3 people should then state in the thread where
they put their -1 that they are, in addition, going to mark the patch as
RwF or Rejected in the CF, and then go do just that. If that isn't done,
and the CfM comes across this situation, they should probably request the
person with the first -1 to make the change instead of doing it for them.
And it doesn't have to be explicit -1s to qualify.

David J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari Mannsåker 2021-08-07 21:29:01 [PATCH] Add tab completion for EXECUTE after EXPLAIN
Previous Message Dagfinn Ilmari Mannsåker 2021-08-07 21:09:19 Re: Tab completion for CREATE SCHEMAAUTHORIZATION