Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Shubham Khanna <khannashubham1197(at)gmail(dot)com>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Date: 2025-03-18 06:37:16
Message-ID: CAKFQuwacztouhg4mgSG7r8AFSMYiSqRb0aq=meZUgEr3YP9wSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Monday, March 17, 2025, Shubham Khanna <khannashubham1197(at)gmail(dot)com>
wrote:

>
> I have added validation for "all" to address both issues at once.
>
>
Usage needs to be changed to refer to object types and we should try and
specify which are valid there too.

The sgml docs need to mention “all” as a valid value and what it means
(namely, if new object types are added and “all” is specified those new
types will be removed as well). Suggest not using it in scripts.

There are still more places where “object type” is needed instead of just
“object”. I’ll pin-point or fix tomorrow if you don’t beat me to them.

It would be good if we could get this to play nicely with —dry-run; maybe
connecting to the source for the queries instead of the target. That would
help alleviate my issue with the current auto-drop behavior.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-03-18 06:48:54 Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Previous Message Masahiko Sawada 2025-03-18 06:34:01 Re: maintenance_work_mem = 64kB doesn't work for vacuum