Re: Improve documentation regarding custom settings, placeholders, and the administrative functions

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Improve documentation regarding custom settings, placeholders, and the administrative functions
Date: 2025-02-27 18:26:37
Message-ID: CAKFQuwaYUtYtWK2zPvZpVSX0Ov-N6RTTx+S8jO3o5SUV-+=wHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 6, 2025 at 8:04 AM Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote:

> On Feb 6, 2025 at 10:49 +0800, David G. Johnston <
> david(dot)g(dot)johnston(at)gmail(dot)com>, wrote:
>
>
> Yes, and when it does it is doing so in lieu of an error, and thus it is
> not returning the value of the setting. It does not mean the value taken
> on by the named parameter is NULL, which is not possible. i.e., SHOW will
> never produce NULL.
>
> Hi,
>
> OK, LGTM.
>
>
Thank you for the review. If you would like to add yourself as the
reviewer and mark this ready to commit here is the commitfest entry.

https://commitfest.postgresql.org/patch/5548/

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2025-02-27 18:31:00 Re: moving some code out of explain.c
Previous Message Robert Haas 2025-02-27 18:24:20 Re: moving some code out of explain.c