| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Document NULL |
| Date: | 2026-01-28 23:34:21 |
| Message-ID: | CAKFQuwaULsfcG=9JmuGO7VXvTOH8hxsuGhwq2zASAYi48SmfRA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 6, 2026 at 12:11 PM Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> wrote:
> Em ter., 11 de nov. de 2025 às 12:34, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
> escreveu:
>
>> I have rebased this; here's v9. I haven't reviewed it in depth, but
>> intend to give it a read and get it pushed sometime in the
>> not-too-distant future, so if anybody wants to review it some more, it'd
>> be appreciated.
>>
>
> - Reading this document I see that he uses "the empty string" but DOCs
> uses more "an empty string".
> Then a few minutes ago I sent a patch [1] to use "an empty string" instead
> of "the empty string".
> If that patch is accepted then this could be done here too.
>
That patch probably isn't going in and the two phrasing do tend to denote
different things even if being correct is hard. I made a couple of tweaks
but in any case either wording tends to adequately convey the necessary
meaning.
> - I think using several commands and their results in a <programlisting>
> is difficult to read,
> mainly because some commands result on 2 or more lines, some an empty
> line,
> so it is difficult to see what command generated what result. Maybe
> separate them into 2 blocks, maybe.
>
>
I decided to do manual inline comments in the output where it seemed
necessary. Let's see how that plays out.
Version 10 attached as a single patch (just needs a commit message)
I brought the introductory paragraph current.
Notably, I went with "Null" as the \pset display null value instead of \N
(find-replace and fixes, did not re-run commands in psql, looks correct
though and it is fairly mechanical).
David J.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-doc-Provide-an-overview-of-NULL-handling.patch | text/x-patch | 72.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-01-28 23:40:49 | Re: pg_plan_advice |
| Previous Message | Andres Freund | 2026-01-28 23:19:32 | Re: [PATCH] llvmjit: always add the simplifycfg pass |