| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: doc: create table improvements |
| Date: | 2025-10-20 11:41:39 |
| Message-ID: | CAKFQuwaEo8dxUmVsmjkb4WBEtKHUazeaN1pwsbDpLsFdANDAkQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, October 20, 2025, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> wrote:
> On Thu, 2025-10-16 at 15:19 +0200, Laurenz Albe wrote:
> > Attached is version 3.
>
> David, do you as the original patch author want to comment?
> The patch is "waiting for author".
>
Thanks,
I question whether “parameter” is even the correct class to assign here and
so would rather avoid the issue by not assigning a class.
“If none is specified, the data will be persistent” would be better written
“If unspecified the data will be persistent” (or, “if not specified…”)
Everything else looks good.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Filip Janus | 2025-10-20 11:53:16 | Re: Proposal: Adding compression of temporary files |
| Previous Message | Nikolay Shaplov | 2025-10-20 11:14:29 | Re: PATCH for BUG #18785: Pointer bmr.rel, dereferenced by passing as 1st parameter to function is checked for NULL later |