| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitrios Apostolou <jimis(at)gmx(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward |
| Date: | 2025-10-13 03:40:34 |
| Message-ID: | CAKFQuwa6jgVj18bRGE3edy2Z=5=DAUGL8efxG2KdWJg12nF0kw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sunday, October 12, 2025, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
wrote:
> On Sunday, October 12, 2025, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>> 2 - 0003
>> ```
>> /*
>> * LZ4 equivalent to feof() or gzeof(). Return true iff there is no
>> - * decompressed output in the overflow buffer and the end of the backing
>> file
>> ```
>>
>> This doesn’t belong to the current patch. But “iff” seems a typo of “if”.
>> You may fix it as you are touching this piece of code.
>>
>
> “iif” is shorthand for “if and only if”. So it isn’t likely to be a typo;
> it only needs to be changed if it is wrong. I haven’t looked to see.
>
Never mind…two f’s, not two i’s …
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-10-13 03:41:15 | Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward |
| Previous Message | David G. Johnston | 2025-10-13 03:39:31 | Re: [PATCH v1] parallel pg_restore: avoid disk seeks when jumping short distance forward |