| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small fix on COPY ON_ERROR document |
| Date: | 2024-01-26 15:04:45 |
| Message-ID: | CAKFQuwa1nLpC9UBLx8jbaqzZxFM9RGuA70xCKGmHMkhn_pKiUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 26, 2024 at 2:30 AM Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> On Fri, 26 Jan 2024 00:00:57 -0700
> "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> > I will need to make this tweak and probably a couple others to my own
> > suggestions in 12 hours or so.
> >
>
>
And here is my v2.
Notably I choose to introduce the verbiage "soft error" and then define in
the ON_ERROR clause the specific soft error that matters here - "invalid
input syntax".
I also note the log message behavior when ignore mode is chosen. I haven't
confirmed that it is accurate but that is readily tweaked if approved of.
David J.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-v2-Improve-ON_ERROR-verbiage-in-COPY-documentation.patch | text/x-patch | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2024-01-26 15:08:29 | Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row |
| Previous Message | Bharath Rupireddy | 2024-01-26 15:02:00 | Re: A failure in t/038_save_logical_slots_shutdown.pl |