Re: doc: Clarify Savepoint Behavior

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: doc: Clarify Savepoint Behavior
Date: 2022-06-09 15:40:44
Message-ID: CAKFQuwa+8KSNbqXxS_k1HidcAnN3vbOYMiWzUispbuCaRfKozA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 9, 2022 at 8:36 AM David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
wrote:

> Hi,
>
> Reposting this on its own thread.
>
>
> https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com
>
> Presently, the open item seems to be whether my novelty regarding the
> reworked example is too much.
>
>
Commentary:

Per documentation comment the savepoint command lacks an example
where the savepoint name is reused. The suggested example didn't
conform to the others on the page, nor did the suggested location
in compatibility seem desirable, but the omission rang true. Add
another example to the examples section demonstrating this case.
Additionally, document under the description for savepoint_name
that we allow for the name to be repeated - and note what that
means in terms of release and rollback. It seems desirable to
place this comment in description rather than notes for savepoint.
For the other two commands the behavior in the presence of
duplicate savepoint names best fits as notes. In fact release
already had one. This commit copies the same verbiage over to
rollback.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-06-09 15:43:22 doc: Clarify Routines and Extension Membership
Previous Message David G. Johnston 2022-06-09 15:39:43 doc: Clarify what "excluded" represents for INSERT ON CONFLICT