From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | alexey(dot)shishkin(at)enterprisedb(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org |
Subject: | Re: correction suggestion for https://www.postgresql.org/docs/17/auth-username-maps.html |
Date: | 2025-07-09 18:39:24 |
Message-ID: | CAKFQuwZu6kZ8ZPvJ3pWXig+6UX4nTVK-hdL_ZS3fSdps=RJQQQ@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On Wed, Jul 9, 2025 at 9:22 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> > On Wed, Jul 9, 2025 at 7:56 AM PG Doc comments form <
> noreply(at)postgresql(dot)org>
> > wrote:
> >> Pls. let me suggest the correction for the
> >> https://www.postgresql.org/docs/17/auth-username-maps.html page.
> >> It has the following sentence:
>
> The existing sentence is pretty mangled English, though.
>
Agreed.
> When the database-username field is a regular expression, it is
> not possible to use \1 within it to refer to a capture from
> the system-username field.
>
> Thoughts?
>
Its good as far a narrow fix goes.
But how about the attached? More invasive but covers the salient points
better, IMO, and less repetitive than having the two fields have their own
basically copy-pasted paragraphs.
I didn't add an example but felt the point "be referenced a single time
within" to be needed since, usefulness not withstanding, writing \1\1 for
database-username works but only the first instance of \1 is replaced.
Also, should we attempt to align this documentation and
pg_ident.conf.sample as pertains to pg-username vs. database-username?
David J.
Attachment | Content-Type | Size |
---|---|---|
v1-0001-doc-Reword-pg_ident.conf-explanation-surrounding-reg.patch | text/x-patch | 4.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-07-09 19:30:04 | Re: correction suggestion for https://www.postgresql.org/docs/17/auth-username-maps.html |
Previous Message | Tom Lane | 2025-07-09 16:22:07 | Re: correction suggestion for https://www.postgresql.org/docs/17/auth-username-maps.html |