| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | cca5507 <cca5507(at)qq(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix incorrect comments in tuplesort.c |
| Date: | 2025-12-07 06:28:18 |
| Message-ID: | CAKFQuwZpZgM56m0F0oWTRZibte6nRkiTEPsrntUPTJRxcHL3=g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Saturday, December 6, 2025, cca5507 <cca5507(at)qq(dot)com> wrote:
> Hi Chao,
>
> Thank you for your reply.
>
> I feed the comment to Github Copilot and he says it's incorrect. The
> "slightly" is just what he suggests.
>
> Your suggestion also LGTM.
>
I don’t think just adding the word “slightly” is a good fix here. Moving
the comment from line 695 here would be better as that explains and gives
reference to why the formula is used, close to the formula itself. It
feels like the identical comment at line 757 also is just a bad copy-paste
outcome and should be removed and probably replaced with one describing the
complicated conditional code it precedes.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-12-07 07:34:22 | Re: WIP - xmlvalidate implementation from TODO list |
| Previous Message | cca5507 | 2025-12-07 05:48:14 | Re: Fix incorrect comments in tuplesort.c |