| From: | David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: rounding up time value less than its unit. |
| Date: | 2014-09-26 21:16:55 |
| Message-ID: | CAKFQuwZmwHSF9_G1WM-LcDrmJroCx-EPSOe4ayzTG291L9tqNQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, September 26, 2014, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> Tom Lane wrote:
>
> > The impression I had was that Stephen was thinking of actually setting
> > min_val to 1 (or whatever) and handling zero or -1 in some out-of-band
> > fashion, perhaps by adding GUC flag bits showing those as allowable
> > special cases. I'm not sure how we would display such a state of affairs
> > in pg_settings, but other than that it doesn't sound implausible.
>
> I would think that if we're going to have "out of band" values, we
> should just use "off", not 0 or -1.
>
>
>
Except "off" is not always semantically correct - some GUCs (not sure which
ones ATM) use zero to mean 'default'. I think -1 always means off.
Instead of 0 and -1 we'd need 'default' and 'off' with the ability to error
if there is no meaningful default defined or if a feature cannot be turned
off.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-09-26 21:22:09 | Re: jsonb generator functions |
| Previous Message | Peter Geoghegan | 2014-09-26 21:00:01 | Re: jsonb generator functions |