Re: BUG #14912: Undocumented: 'psql -l' assumes database 'postgresql' not $USER

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: mhwood(at)ameritech(dot)net
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14912: Undocumented: 'psql -l' assumes database 'postgresql' not $USER
Date: 2017-11-16 21:27:06
Message-ID: CAKFQuwZYLRkGH2wisFk74rSRnOt4qwM+LW8C3t+uZSr+thuTmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Nov 16, 2017 at 10:17 AM, <mhwood(at)ameritech(dot)net> wrote:

> The following bug has been logged on the website:
>
> Bug reference: 14912
> Logged by: Mark Wood
> ​[...]​
>
> That is true *unless* using -l / --list. The code shows that this option
> defaults to 'postgresql' instead, overriding the libpq defaulting.
>

​It actually defaults to "postgres"

​[...]​

> The actual behavior may be reasonable, but if so it should be documented as
> an exception for the --list function.
>

I can see an argument for either default, but given that this invocation
has never defaulted to the user's database I cannot see changing it.

I agree this should be considered a doc bug and back-patched. Possible
verbiage for master below and attached.

Changing the "Usage" section to point out this exception to the rule seems
undesirable.

David J.

diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index e520cdf3ba..ad2a505b1e 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -283,7 +283,9 @@ EOF
<listitem>
<para>
List all available databases, then exit. Other non-connection
- options are ignored. This is similar to the meta-command
+ options are ignored. If an explicit database name is not
+ found the <literal>postgres</literal> database, not the user's,
+ will be targeted for connection. This is similar to the meta-command
<command>\list</command>.
</para>
</listitem>

Attachment Content-Type Size
psql-list-command-dbname-fix.patch application/octet-stream 654 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message jens.with 2017-11-16 22:44:01 BUG #14913: Test for aggregates fails
Previous Message mhwood 2017-11-16 17:17:35 BUG #14912: Undocumented: 'psql -l' assumes database 'postgresql' not $USER