Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DROP relation IF EXISTS Docs and Tests - Bug Fix
Date: 2020-07-14 13:54:50
Message-ID: CAKFQuwYnCH_SS5CWGFo-Qv=gD07SdSbgYtY+B1d6C6fh5qWGkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 14, 2020 at 5:40 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:

> On Tue, Jul 14, 2020 at 07:25:56AM +0200, Pavel Stehule wrote:
> > út 14. 7. 2020 v 0:37 odesílatel David G. Johnston <
> david(dot)g(dot)johnston(at)gmail(dot)com> napsal:
> > > On Mon, Jul 13, 2020 at 2:12 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > I think so now all changes are correct and valuable. I''l mark this patch
> > as ready for commit
>
> This is failing relevant tests in cfbot:
>
> drop_if_exists ... FAILED 450 ms
>
>
Oops, did a minor whitespace cleanup in the test file and didn't re-copy
expected output. I'm actually going to try and clean up the commenting in
the test file a bit to make it easier to read, and split out the glossary
changes into their own diff so that the bulk of the changes can be
back-patched.

Further comments welcome so I'm putting it back into needs review for the
moment while I work on the refactor.

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-07-14 13:56:16 Re: DROP relation IF EXISTS Docs and Tests - Bug Fix
Previous Message Dave Cramer 2020-07-14 13:36:37 Re: Binary support for pgoutput plugin