| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Li Japin <japinli(at)hotmail(dot)com>, kuroda(dot)hayato(at)fujitsu(dot)com |
| Subject: | Re: About to add WAL write/fsync statistics to pg_stat_wal view |
| Date: | 2021-03-08 19:47:31 |
| Message-ID: | CAKFQuwYjiohvS9C5Uiq+jn7eQPFtqEpPLa7-M2HQZq7dh3K+PA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 8, 2021 at 8:48 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
wrote:
>
> Thanks for updating the patch! I applied cosmetic changes to that.
> Patch attached. Barring any objection, I will commit this version.
>
Read over the patch and it looks good.
One minor "the" omission (in a couple of places, copy-paste style):
+ See <xref linkend="wal-configuration"/> for more information about
+ internal WAL function <function>XLogWrite</function>.
"about *the* internal WAL function"
Also, I'm not sure why you find omitting documentation that the millisecond
field has a fractional part out to microseconds to be helpful.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-08 20:12:39 | Re: Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[] |
| Previous Message | Stephen Frost | 2021-03-08 19:42:53 | Re: automatic analyze: readahead - add "IO read time" log message |