Re: [patch] [doc] Clarify that signal functions have no feedback

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [patch] [doc] Clarify that signal functions have no feedback
Date: 2020-11-02 16:02:21
Message-ID: CAKFQuwYeMVLTqAfAx7HHYf+N_jaMpvYDS-10ff4F-6uqzgWEEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 27, 2020 at 1:19 AM Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 2020-10-13 00:43, David G. Johnston wrote:
> > Over in Bug# 16652 [1] Christoph failed to recognize the fact that
> > signal sending functions are inherently one-way just as signals are. It
> > seems worth heading off this situation in the future by making it clear
> > how signals behave and, in the specific case of pg_reload_conf, that the
> > important feedback one would hope to get out of a success/failure
> > response from the function call must instead be found in other locations.
>
> I agree that the documentation could be improved here. But I don't see
> how the added advice actually helps in practice. How can you detect
> reload errors by inspecting pg_settings etc.?
>

I decided I was trying to be too thorough here by including stuff other
than the file related view added mainly for this purpose (of which I missed
including the one pertinent to the bug report - pg_hba_file_rules).

Attached is a version 2 patch listing only pg_hba_file_rules and
pg_file_settings as the "before reload" places (as they do show current
file contents) to validate that the server understands the newly changed
contents of the pg_hba.conf file and the configuration settings.

David J.

Attachment Content-Type Size
v2-doc-pg-reload-conf-signaling.patch application/octet-stream 2.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2020-11-02 16:18:03 Re: how to replicate test results in cf-bot on travis
Previous Message Peter Eisentraut 2020-11-02 15:59:11 Re: Improper use about DatumGetInt32