Re: cannot restore schema with is not distinct from on hstore since PG 9.6.8

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Marc Cousin <cousinmarc(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: cannot restore schema with is not distinct from on hstore since PG 9.6.8
Date: 2018-07-13 21:17:30
Message-ID: CAKFQuwYAY3hV9yE3D9SiaSfM9JJBu9DFOh0y3C6ZKE1s2OSY8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Jul 13, 2018 at 1:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> So this is all pretty messy, but on the bright side, fixing it would allow
> cleaning up some ancient squishy coding in ruleutils.c. It wouldn't be
> controversial as just a v12 addition, perhaps ... but do we have a choice
> about back-patching? Dump/restore failures are not good.
>

I think serious consideration needs to be given to ways to allow the user
of pg_dump/pg_restore to choose the prior, less secure, mode of operation​.

IMO the risk surface presented to support back-patching the behavioral
changes was not severe enough to do so in the first place. I'm presuming
undoing the back-patch will be shot down without mercy but at least
consider an escape hatch for unafflicted secure systems that just happen to
depend on search_path more than a super-hardened system would.

David J.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2018-07-13 21:23:40 Re: cannot restore schema with is not distinct from on hstore since PG 9.6.8
Previous Message Tom Lane 2018-07-13 20:54:15 Re: cannot restore schema with is not distinct from on hstore since PG 9.6.8

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2018-07-13 21:19:29 Re: pgsql: Fix parallel index and index-only scans to fall back to serial.
Previous Message Alvaro Herrera 2018-07-13 21:11:31 Re: partition pruning doesn't work with IS NULL clause in multikey range partition case