| From: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_plan_advice |
| Date: | 2026-03-06 14:46:24 |
| Message-ID: | CAKFQuwY4i6xXCRHd=ccrFz0sQOfiWRxhobiBrzyK0rzu1-Y33Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 4, 2026 at 9:20 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Mar 4, 2026 at 10:45 AM David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> > I do need to work in a way to better annotate/comment on the why of
> these. Any suggestions for a better flow or feedback format? Inline
> comments wrapped in sgml comments? Or just copy the diff into the email
> body and inline comment there - leaving the original diff attachment as-is?
>
> My suggestion is to break these fixes up into three categories: clear
> errors, stylistic suggestions, substantive concerns.
>
>
Thank you for putting in the time to respond. That was quite helpful.
I've tweaked my tooling to help me remember to do this going forward.
David J.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-03-06 14:48:38 | Re: pg_stat_io_histogram |
| Previous Message | Pavel Borisov | 2026-03-06 14:45:06 | Re: Odd code around ginScanToDelete |