Re: ALTER TABLE: warn when actions do not recurse to partitions

From: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
Date: 2026-03-11 16:39:19
Message-ID: CAKAnmmLWdEvFR+-+5HXzMEnd8fLfyvkK4QxtSHMBhoXC5Qvcug@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 11, 2026 at 3:05 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:

> Are you concerning that rendering the full message text is the extra work?
> This is not a hot path, so I don’t think that would be a big deal.
> Actually, adding two more fields sounds more expensive

Well, the recurring creation and freeing of the strings is the part that
seems inefficient. But you don't even need to store the strings at all if
you are tracking the action+rel. In such a case, the final strings can be
created on the fly inside of EmitPartitionNoRecurseNotice, right? Then you
just need a list to store the combos of action+relation.

Yes, as SET SCHEMA doesn’t go through the standard ALTER TABLE process:
> AlterTable() -> ATController() -> ATPrepCmd().
>
> If you get some idea, please let me know.
>

Nothing worth the trouble, to be honest. As you rightly pointed out, this
is not a hot path.

Cheers,
Greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Pang 2026-03-11 16:44:07 [PATCH] Fix premature timeout in pg_promote() caused by signal interruptions
Previous Message Daniel Verite 2026-03-11 16:28:05 Re: Change initdb default to the builtin collation provider