Re: Logging which interface was connected to in log_line_prefix

From: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
To: Cary Huang <cary(dot)huang(at)highgo(dot)ca>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Logging which interface was connected to in log_line_prefix
Date: 2024-05-01 17:04:22
Message-ID: CAKAnmmKfs=do+Z3ch_y9dFRno5VvjPxFv27ZtnnHtBQS9RQE4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for taking the time to review this. I've attached a new rebased
version, which has no significant changes.

> There is a comment in the patch that states:
>
> /* We do not need clean_ipv6_addr here: just report verbatim */
>
> I am not quite sure what it means, but I am guessing it means that the
> patch does not need to format the IPv6 addresses in any specific way.

Yes, basically correct. There is a kluge (their word, not mine) in
utils/adt/network.c to strip the zone - see the comment for the
clean_ipv6_addr() function in that file. I added the patch comment in case
some future person wonders why we don't "clean up" the ipv6 address, like
other places in the code base do. We don't need to pass it back to anything
else, so we can simply output the correct version, zone and all.

Cheers,
Greg

Attachment Content-Type Size
add_local_interface_to_log_line_prefix.v2.patch application/octet-stream 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ayush Vatsa 2024-05-01 17:09:49 Query Discrepancy in Postgres HLL Test
Previous Message Cary Huang 2024-05-01 16:44:14 Re: Support tid range scan in parallel?